[TYPO3-core] RFC: #11880: Add a the default width to the output if no width is set
Steffen Kamper
info at sk-typo3.de
Fri Sep 4 20:40:44 CEST 2009
Hi georg,
Georg Ringer schrieb:
> v2 using $defaultColumnWidth instead of $maxW
i examined the problem too.
Your fix is a quickfix which doesn't solve the problem but works for the
expected output.
The Problem is, that CSC use the text/pic element as text with *only*
pictures.
If any extension tries to use the element with custom "images" which can
be any media (as you do in rgmediaimages, or DAM wants to do with any
media files) then the problem starts by calling IM / GM for render the
file unless if it's renderable.
Fixing this would require a rewrite of the element and CSC which is too
much for 4.3, anyway it should be a task for 4.4 to change this element
to a layout element only with customizable content (images, media,
custom, other CE's etc)
So my +1 on reading v2
btw - as the code is difficult to read anyway i would prefer a
precalculated var like:
$imgWidth = intval($this->cObj->data['imagewidth']) == 0) ?
$defaultColumnWidth : $this->cObj->data['imagewidth'];
and then use it in the following 2 lines
vg Steffen
More information about the TYPO3-team-core
mailing list