[TYPO3-core] RFC: #11771: Cleanup of tceforms.php

[Rupert Germann]

hi

attached is a new patch (v2) where I changed the following:
- made changed lines CGL compatible
- removed some forgotten reset()s
- changed $setAll = $unSetAll = array(); to the more readable version
- removed not used var $itemName (line 4312)

and I can confirm that there is no functional change in this patch.

the missing variable $field has actually no effect and adding it removes 
only a warning in the editor (and php notizes)

+1 by reading and testing for v2

btw: good catch Steffen! :-)

greets
rupert




Steffen Ritter schrieb:
> Steffen Kamper schrieb:
>> Hi Steffen,
>>
>> Steffen Ritter schrieb:
>>
>>> +1 by reading,
>>> but one question, what does this function do, and why worked it 
>>> without the parameter? If it is not needed - as it has not been 
>>> there, why not completely remove it from the function body.
>>>
>>
>> in the function the $field is used as array key:
>> $rowCopy[$field] = $imgPath;
>> and needed for the call t3lib_BEfunc::thumbCode
>>
>> It works with empty $field but raise a warning, which i eleminated.
>>
>>> I would like you to split up when committing, so that the functional 
>>> change of previeFieldValue could be reverted alone
>>>
>>
>>
>> no functional change, only warnings eleminated, so no need to split.
>>
>> vg Steffen
> ok, then, my +1 stays :P