[TYPO3-core] RFC #12351: Clean-up SQL parser and SQL engine

[Ernesto Baschny [cron IT]]

Hi Xavier,

Xavier Perseguers schrieb:

> This is an SVN patch request.
> 
> Type: Cleanup
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=12351
> http://bugs.typo3.org/view.php?id=12349 (related patch for DBAL if you
> need it)
> 
> Branches: trunk
> 
> Problem:
> This patch adds visibility to methods of t3lib_sqlengine and
> t3lib_sqlparser and applies CGL on modified lines.
> 
> Purpose is to ease creation of unit tests.

You choose to make these functions private:

t3lib_sqlparser:
parseSELECT
parseUPDATE
parseINSERT
parseDELETE
parseEXPLAIN
parseCREATETABLE
parseALTERTABLE
parseDROPTABLE
parseCREATEDATABASE
nextPart
getValue
getValueInQuotes
parseStripslashes
parseError
trimSQL
compileSELECT
compileUPDATE
compileDELETE

t3lib_sqlengine:
processAccordingToConfig

How can you be sure that noone else is accessing / using these function
as they have always been public before?

Cheers,
Ernesto