[TYPO3-core] RFC: #12237: Use flash-messages in user-settings
Steffen Kamper
info at sk-typo3.de
Mon Oct 19 16:30:27 CEST 2009
Hi Masi,
Martin Kutschker schrieb:
> Steffen Kamper schrieb:
>> Hi Georg,
>>
>> generally good, but it's strange if there is no message if you save
>> other settings.
>>
>> Attached patch also shows when user settings were saved.
>>
>> +1 by reading and testing.
>
> +1 by reading as I assume that the properties $PASSWORD_UPDATED and $SETUP_UPDATED existed before
> this patch. If not please use lower case names (in camel case).
>
PASSWORD_UPDATED was there before, i added SETUP_UPDATED. Both weren't
declared before. But you're right to change them to lowerCamelCase.
> And btw I suggest to use "protected $PASSWORD_UPDATED=false" as declaration.
>
it's not boolean as it can be -1,0 and 1. I set it to 0
See attached patch
vg Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 12237_v3.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20091019/027e0e26/attachment-0001.asc>
More information about the TYPO3-team-core
mailing list