[TYPO3-core] RFC: #12168: Empty line in general header comment
Susanne Moog
typo3 at susannemoog.de
Sun Oct 18 13:32:07 CEST 2009
Hey Steffen,
Steffen Kamper schrieb:
> JoH asenau schrieb:
>>
>> But this is the desired result.
>> There should be an empty line between individual comments and the
>> original
>> TYPO3 copyright notice to separate this official notice clearly from the
>> rest of the comment(s).
>> But there's still a bug, since the empty line should only be there if
>> there
>> really is an individual comment.
>>
>> So -1 by reading.
>>
>
> before -1 you should test or read the code carefully - what i posted is
> the result after the patch
I'm afraid Joey seems to be correct. The result after your patch (with
your TS line) is:
<!--
HELLO WORLD, I'M TYPOSCRIPT :)
This website is powered by TYPO3 - inspiring people to share!
TYPO3 is a free open source Content Management Framework initially
created by Kasper Skaarhoj and licensed under GNU/GPL.
TYPO3 is copyright 1998-2009 of Kasper Skaarhoj. Extensions are
copyright of their respective owners.
Information and contribution at http://typo3.com/ and http://typo3.org/
-->
The result before was:
<!--
HELLO WORLD, I'M TYPOSCRIPT :)
This website is powered by TYPO3 - inspiring people to share!
TYPO3 is a free open source Content Management Framework initially
created by Kasper Skaarhoj and licensed under GNU/GPL.
TYPO3 is copyright 1998-2009 of Kasper Skaarhoj. Extensions are
copyright of their respective owners.
Information and contribution at http://typo3.com/ and http://typo3.org/
-->
So there is a tab missing in front of the TS line, but the empty line
for separation is correct.
Best regards,
Susanne
--
Susanne Moog
NEUSTA GmbH - www.neusta.de
More information about the TYPO3-team-core
mailing list