[TYPO3-core] RFC #12187: Add some flashmessages to EM (part 3)

[Susanne Moog]

Hi,

Francois Suter schrieb:
> Hi,
> 
>>> Solution:
>>> Add a flashmessage
>> Attached an updated patch which reflects the API changes.
> 
> +1 on testing and reading attached v3.
> 
> I made the following changes:
> 
> - I introduced 2 separate messages for install and removal. I know the
> message you added followed an existing pattern, but I don't think it's a
> good idea, because such sentence structure might not make sense in some
> languages.
> - Furthermore your patch localized the verb part of the sys_log message,
> whereas the rest is not localized, so that didn't make much sense.

+1 by reading and testing if you remove the superfluous third parameter
on the sprintf call (sprintf($GLOBALS['LANG']->getLL($messageLabel),
$extKey, $action)).

Best regards,

Susanne

-- 
Susanne Moog
NEUSTA GmbH - www.neusta.de