[TYPO3-core] RFC #12066: Code cleanup: Add some constants

[Niels Pardon]

+1 by reading with the following changes

The patch no longer applies to the current trunk. There are 3 unmatched
chunks. Could you please update the patch? I will then test it.


The following change is a bit strange. Looks like the original and the
new code are on one line? And Kasper's name looks a bit broken.

Index: typo3/sysext/info_pagetsconfig/class.tx_infopagetsconfig_webinfo.php
=======================================

---
typo3/sysext/info_pagetsconfig/class.tx_infopagetsconfig_webinfo.php
(revision 6055)

+++
typo3/sysext/info_pagetsconfig/class.tx_infopagetsconfig_webinfo.php
(working copy)

@@ -27,7 +27,6 @@

/**
* Contains class for Page TSconfig wizard
*
- * Revised for TYPO3 3.7 June/2004 by Kasper Skￜrhￜ+ * Revised for
TYPO3 3.7 June/2004 by Kasper Skï¿œrhï¿œj
* XHTML compliant
*
* @author Kasper Skï¿œrhï¿œj <kasperYYYY at typo3.com>


The following change in t3lib_div could be a bit beautified "TAB (TAB)":

@@ -2375,7 +2375,7 @@

* @param string tag-prefix, eg. a namespace prefix like "T3:"
* @param integer Current recursion level. Don't change, stay at zero!
* @param string Alternative document tag. Default is "phparray".
- * @param integer If greater than zero, then the number of spaces
corresponding to this number is used for indenting, if less than zero -
no indentation, if zero - a single chr(9) (TAB) is used
+ * @param integer If greater than zero, then the number of spaces
corresponding to this number is used for indenting, if less than zero -
no indentation, if zero - a single TAB (TAB) is used
* @param array Options for the compilation. Key "useNindex" => 0/1
(boolean: whether to use "n0, n1, n2" for num. indexes); Key
"useIndexTagForNum" => "[tag for numerical indexes]"; Key
"useIndexTagForAssoc" => "[tag for associative indexes"; Key
"parentTagMap" => array('parentTag' => 'thisLevelTag')
* @param string Stack data. Don't touch.
* @return string An XML string made from the input content in the array.


Please check the comments of the changes in t3lib/config_default.php for
similar strange comments, e.g. "Default is ONE_HOUR seconds = 1 hour."


Same in t3lib/class.t3lib_xml.php "LF (newslines)":

@@ -245,7 +245,7 @@

/**
* Internal function for adding the actual content of the $row from
$table to the internal structure.
* Notice that only fields from $table that are listed in
$this->XML_recFields[$table] (set by setRecFields()) will be rendered
(and in the order found in that array!)
- * Content from the row will be htmlspecialchar()'ed, UTF-8 encoded and
have chr(10) (newlines) exchanged for '<newline/>' tags. The element
name for a value equals the fieldname from the record.
+ * Content from the row will be htmlspecialchar()'ed, UTF-8 encoded and
have LF (newlines) exchanged for '<newline/>' tags. The element name for
a value equals the fieldname from the record.
*
* @param string Table name
* @param array Row from table to add.


Please check the comments of the changes in
t3lib/class.t3lib_userauth.php for similar strange comments, e.g. "or
use ONE_DAY seconds if $this->lifetime is 0"


IIRC in t3lib_constants the // comments should be indented by one tab
according to the TYPO3 CGL.

Greets,

Niels