[TYPO3-core] RFC #12506: Bug: JSMENU does not respect mount point overlays

[Joerg Wagner [DigiLog]]

Anything else I can do to have this patch and the one for #12505 committed?
It took so much time to track down these problems and find a solid 
solution that it would really be a pity to lose that effort and stay 
with a widely broken JSMENU.

Patch attached again.
Cheers, Jörg.



Joerg Wagner [DigiLog] schrieb am 08.11.2009 19:17:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=12506
> 
> Branches:
> TYPO3_4-2 & trunk
> TYPO3_4-3 & trunk
> 
> Problem:
> JSMENU calculates wrong links for its menu items if the link is an 
> overlay mount point. So if the checkbox "Substitute Mount Point (this 
> page) with Mounted page" is checked in the page properties of a mount 
> point page, JSMENU creates a wrong link for this page (the "&MP=" 
> variable in the query string is completely missing).
> 
> Solution:
> The algorithm for JSMENU link generation in 
> /typo3/sysext/cms/tslib/class.tslib_menu.php only accounts for normal 
> mount points (adding mounted children to a page) but completely ignores 
> the possibility of overlay mount points. The attached patch (for 4.2.10 
> and 4.3.0beta2) adds the needed code for MP overlays. It is thoroughly 
> tested in a bunch of JSMENU configurations and a life system.
> 
> Cheers, Jörg.
> 
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch4.3.0RC1_jsmenu_mpovl_V2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20091126/153dbf16/attachment-0001.txt>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch4.2.10_jsmenu_mpovl_V2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20091126/153dbf16/attachment-0001.asc>