[TYPO3-core] FYI24 #12492: Code cleanup: Reports: CGL and SVN cleanup

Ingmar Schlecht ingmar at typo3.org
Wed Nov 25 12:40:13 CET 2009


Hi Francois,

a FYI24 at this time is not so good, because the patch should be either
committed today (before RC2 is released) or to 4.4 trunk after 4.3 final
will be released.

So I would suggest you to commit it later today if no-one objects.

cheers
Ingmar

Francois Suter schrieb:
> This is an SVN patch request.
> 
> Type: Code cleanup
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=12492
> 
> Branches:
> Trunk
> 
> Problem:
> There are some little CGL inconsistencies in the Reports module (and the
> statuses provided by the Install Tool). Also all new files miss the $Id:
> $ marker for SVN and some don't have the correct SVN properties (line
> endings, mime type, keywords).
> 
> Solution:
> Improve CGL compliance, add $Id: $ marker, set proper SVN properties.
> 
> Notes:
> I'm just not sure about the SVN properties part, if this is the right
> way to fix them or if it should be done some other way.
> It makes the patch a bit hard to read, because SVN considers that all
> lines changed for files that have their line ending properties changed.
> I tried excluding whitespace changes, but it doesn't help.
> If this is the right way of going about such changes, I'll commit this
> patch in 24h.
> 
> Cheers
> 


More information about the TYPO3-team-core mailing list