[TYPO3-core] RFC #12505: Bug: JSMENU's showActive is broken

[Susanne Moog]

Susanne Moog schrieb:
> Joerg Wagner [DigiLog] schrieb:
>> This is an SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=12505
>>
>> Branches:
>> TYPO3_4-2 & trunk
>> TYPO3_4-3 & trunk
>>
>> Problem:
>> The implementation of the JSMENUITEM property "showActive" is (very)
>> flawed. It only works for a small subset of all possible HMENU
>> configurations.
>>
>> Solution:
>> The problem is simple to solve. The JSMENU code to determine if a page
>> is active is very simplistic and will not work in a large number of more
>> complex cases. Funny thing is that there is a dedicated method in the
>> same PHP file that does the job and does it right. JSMENU just does not
>> use it. The patches contain a one-line fix that is thoroughly tested in
>> many HMENU constellations.
> 
> +1 by reading and testing with your test setup. Looks like a nobrainer
> to me.
> 

sry, forgot one thing: please make your patches against the root of your
TYPO3 directory, else they don't apply. Attached is an updated version
with correct src path.

Best regards,

Susanne
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch4.3.0beta2_jsmenu_showactive_v2.diff
URL: <http://lists.typo3.org/pipermail/typo3-team-core/attachments/20091122/271f77bc/attachment-0001.asc>