[TYPO3-core] RFC: Cleanup #12278: Move t3lib_matchCondition::whichDevice() to t3lib_utility_Client::getDeviceType()

[Jeff Segars]

Oliver Hader wrote:
> This is an SVN patch request.
> 
> Type: Cleanup
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=12278
> 
> Branch: Trunk
> 
> Problem:
> The method t3lib_matchCondition::browserInfo() was moved to
> t3lib_utility_Client::getBrowserInfo() in RFC #11585. For the remaining
> method whichDevice() the same movement is still pending.
> 
> Solution:
> Move the functionality of t3lib_matchCondition::whichDevice() to
> t3lib_utility_Client::getDeviceType().
> 
> olly
> 

One issue was introduced by line 45 of this patch (inside getDeviceType)
+ $hookResult = t3lib_div::callUserFunction($hookFunction, 
$hookParameters, NULL);

The third argument is passed by reference, so setting a NULL value 
directly does not work and instead needs to be assigned through a variable.

getBrowserInfo() also has the same issue, introduced in #11585.

Thanks,
Jeff