[TYPO3-core] RFC #12455: OpenID authentication does not work with PHP 5.3

[Dmitry Dulepov]

Hi!

Rupert Germann wrote:
> had the same error as steffen, might be a windows specific problem.
> On which system(s) does the patch work for you.

I use Mac OS X.

> mine, too. did you test it?

No, I didn't have time. We had major issues with OpenID logins for the past several weeks and made a lot of adjustments to OpenID library. But our tests are made with OpenID extension inside 4.2 environment. This patch works there. If 4.3 has problems with it, I think some more files should be included in 4.3. In the bug tracker it says "Fatal error: Class 't3lib_error_Exception' not found in...". Either I do not understand anything or autoloader fails to load this class for some reason. Consumer.php in my version definitely does not use t3lib_error_Exception.

What do you think?

I had a quick look at Rupi's patch and I think it is dangerous. The following piece of code is an example:

=======================
@@ -573,7 +573,7 @@
      * @param type_uri: The URI for the attribute
      * @param values: A list of values to send for this attribute.
      */
-    function setValues($type_uri, &$values)
+    function setValues($type_uri, $values)
     {
         $this->data[$type_uri] =& $values;
     }
=======================

Here $values were passed by reference and this reference is assigned to $this->data[$type_uri]. It means that modifying $this->data[$type_uri] will modify original variable passed to setValues(). In Rupi's version original variable will not not be modified. May be it is not important but than assignment by reference to $this->data[$type_uri] does not make any sense for the passed parameter.

Do you want to say that it is not a problem to have code like this one? It is not ready to be committed anyway.

-- 
Dmitry Dulepov
"Trust me, I am a doctor!" (c) Gregory House, M.D.