[TYPO3-core] RFC #12505: Bug: JSMENU's showActive is broken

Joerg Wagner [DigiLog] news.netfielders.de at digilog.de
Mon Nov 16 17:46:31 CET 2009


Hello core team,

is there anything I can do to motivate you to review the two JSMENU 
patches I posted one week ago?

Maybe:
- More details on a testing scenario (page tree, TS code)?
- Text description of what the patches do?
- SQL dump of a rudimentary TYPO3 installation containing everything to 
reproduce the two errors?

Tracking down and correcting these bugs took me nearly two days so it 
would really be a pity not to use the results. As said the patches are 
thoroughly tested and I am convinced that they are complete in any 
aspect. Without these patches JSMENUs will not work in a rather large 
number of implementations as the original code is really quite buggy.

Cheers,
Jörg.


Joerg Wagner [DigiLog] schrieb:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=12505
> 
> Branches:
> TYPO3_4-2 & trunk
> TYPO3_4-3 & trunk
> 
> Problem:
> The implementation of the JSMENUITEM property "showActive" is (very) 
> flawed. It only works for a small subset of all possible HMENU 
> configurations.
> 
> Solution:
> The problem is simple to solve. The JSMENU code to determine if a page 
> is active is very simplistic and will not work in a large number of more 
> complex cases. Funny thing is that there is a dedicated method in the 
> same PHP file that does the job and does it right. JSMENU just does not 
> use it. The patches contain a one-line fix that is thoroughly tested in 
> many HMENU constellations.
> 
> Cheers, Jörg.
> 


More information about the TYPO3-team-core mailing list