[TYPO3-core] RFC #12506: Bug: JSMENU does not respect mount point overlays

[Joerg Wagner [DigiLog]]

Hello core team,

is there anything I can do to motivate you to review the two JSMENU 
patches I posted one week ago?

Maybe:
- More details on a testing scenario (page tree, TS code)?
- Text description of what the patches do?
- SQL dump of a rudimentary TYPO3 installation containing everything to 
reproduce the two errors?

Tracking down and correcting these bugs took me nearly two days so it 
would really be a pity not to use the results. As said the patches are 
thoroughly tested and I am convinced that they are complete in any 
aspect. Without these patches JSMENUs will not work in a rather large 
number of implementations as the original code is really quite buggy.

Cheers,
Jörg.


Joerg Wagner [DigiLog] schrieb:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=12506
> 
> Branches:
> TYPO3_4-2 & trunk
> TYPO3_4-3 & trunk
> 
> Problem:
> JSMENU calculates wrong links for its menu items if the link is an 
> overlay mount point. So if the checkbox "Substitute Mount Point (this 
> page) with Mounted page" is checked in the page properties of a mount 
> point page, JSMENU creates a wrong link for this page (the "&MP=" 
> variable in the query string is completely missing).
> 
> Solution:
> The algorithm for JSMENU link generation in 
> /typo3/sysext/cms/tslib/class.tslib_menu.php only accounts for normal 
> mount points (adding mounted children to a page) but completely ignores 
> the possibility of overlay mount points. The attached patch (for 4.2.10 
> and 4.3.0beta2) adds the needed code for MP overlays. It is thoroughly 
> tested in a bunch of JSMENU configurations and a life system.
> 
> Cheers, Jörg.
>