[TYPO3-core] FYI48: #12545: t3lib_div::linkThisScript isn't xhtml compatibel
Martin Kutschker
masi-no at spam-typo3.org
Tue Nov 10 21:30:37 CET 2009
Steffen Kamper schrieb:
> Hi,
>
> following patch will be committed after 48 hours if noone complain.
I do complain.
You add a new parameter, but don't add a phpDoc comment. The new parameter changes the behaviour of
the function. Before you're change it was the duty of the caller to use htmlspecialchars() on t´he
result of the function. Now this is on by default.
And I suggest to use htmlspecialchars() and not a homebrew ampersand replacing for proper escaping.
Masi
More information about the TYPO3-team-core
mailing list