[TYPO3-core] FYI #12499: Call to deprecated method t3lib_userAuth::redirect()

[Martin Kutschker]

Martin Kutschker schrieb:
> Rupert Germann schrieb:
>> Hi,
>>
>> the following patch was committed to trunk (follow-up to 12420)
>> rev 6363
>>
>> Type: Bugfix
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=12499
>>
>> Branches: Trunk
>>
>> Problem:
>> function start() in class t3lib_userAuth calls the deprecated method
>> t3lib_userAuth::redirect()
>> this floods the deprecation log with entries.
>>
>> Solution:
>> remove the call to this function
>> it is marked as deprecated since TYPO3 3.6
> 
> But this changes the behaviour *now*, not in 4.5

I've seen only now that this was a FYI and not a FYI24. Please ask Olly about the change of yours.
IMHO it must either be reverted or changed in some way (see my proposal) that the deprecated call is
executed in 4.3 and 4.4.

After having a second look, I have another suggestion:

function redirect() {
	if (!$this->userid && $this->auth_url) {
		t3lib_div::deprecationLog('Redirection after login via PHP include is deprecated.');
		include ($this->auth_include);
		exit;
	}
}

Now only an execution of the "hook" is logged.

Of course both ideas can be combined.

Masi