[TYPO3-core] RFC #12022: PHP-5.3 warning about missing references with some extensions

[Oliver Hader]

Hi,

Martin Kutschker schrieb:
> Rupert Germann schrieb:
>> Hi,
>>
>> this is a SVN patch request.
>>
>> Type: Bugfix
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=12022
>>
>> Branches: Trunk, (and possibly older, will test asap)
>>
>> Problem:
>> when TYpo3 is running under PHP 5.3 and you have an extension on a page
>> which uses a reference in its main function
>>
>> function main($content, &$conf) ...
>>
>> you'll get the following warning:
>>
>> Core: Error handler (FE): PHP Warning: Parameter 2 to
>> tx_ttnews::main_news() expected to be a reference, value given in
>> C:\xampp\xampp\htdocs\typo3\dummy-4.2.9\typo3\sysext\cms\tslib\class.tslib_content.php
>> line 6605
>>
>> Hint: there is no error in tt_news - I just simulated it by adding the
>> reference ;-)
>>
>> Solution:
>> add the missing reference operator in class tslib_content function
>> callUserFunction()
> 
> I don't think that $content and $conf were ever meant to be passed by reference. So IMHO it's the
> extensions that should be changed, not the Core.

Thanks Rupi for the patch. However, I'd also say that the extension is
buggy and not the Core. Even the kickstarter does not create references
in the main($content, $conf) method...

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3