[TYPO3-core] RFC #12244: Improve locallangXMLOverride feature

[Oliver Hader]

Hi Steffen,

Steffen Gebert schrieb:
> Am 01.11.2009, 15:09 Uhr, schrieb Christian Kuhn <lolli at schwarzbu.ch>:
> 
>> +1 on reading.
>>
>> Some remarks, though:
>> - Naming: If we deprecate [BE][XLLfile] anyway, we could go for a better
>> name, thats why [locallangXMLOverride] was chosen.
> 
> Okay. Changed in the attached patch. IMHO it might also be confusing, to
> have a XLLfile array in two different places.
> 
>> - Naming: I personally don't care if we use [SYS] or [EXT], any
>> arguments?
> Like Benni, I prefer SYS, too. EXT conveys the impression that it works
> only for extension labels and not for core (of course, we know that
> core's label also come from EXT:lang).
> 
>> - Using an array: This will implement the exact same problem we have
>> with hooks: If several extensions register overrides to the same file,
>> the order is given by the load order in ['extList']. This is no critism,
>> but generally poor design in this area. Or consider this case: You want
>> to override a label file from an extension, but your extension is loaded
>> before the ext you want to override -> nothing happens. Who did not
>> waste some time with those problems before?
> 
> At least you could reinstall your EXT to load it at a later point, of
> course.
> My patch is at least an improvement of exactly this situation as the
> conflict is now only on a per-label basis, not on per-file as before
> (but I'm sure, you know this ;) ).
> I could imagine a concept like services with running only under several
> prerequisites and with different priorities. But of course, everything
> would get more complicated.
> 
> I would be very happy to have this in before beta3!

+1 by reading

However, I was not able to test the behaviour with the test stuff you
provided. My "logout" button has still the same label. Maybe you can
provide a unit test for this part instead of testing it with external
extensions...

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3