[TYPO3-core] RFC #5120 / #8915: SQL parse error in "Who is online" BE list

[Xavier Perseguers]

Hi,

Here is a friendly REMINDER.

I'm doing all what I can not to bother you anymore with DBAL bugs as I know how it is... This is why I sent RFC #12440.

Now, sometimes, just as with this RFC, I still need some feedback for bugs we (the DBAL team and its surrounded people) find and fix.

This patch can be tested very easily *without any DBAL install at all*!

Please simply apply patch, go to BE module to see who is online and give your +1 by testing as you'll confirm that the module still works as before for your MySQL install. However, this tiny change in 
SQL let us, we DBAL users, start to use this module too!

This is a gremlin (easy to spot with RFC number). Please allow this to be closed before beta3.

Thanks very much for your effort in reviewing this patch and helping me make DBAL a bit more usable.

Regards

Xavier Perseguers wrote:
> Hi,
> 
> Just figured out by trying to apply this patch to another Oracle 
> instance that it could not apply from typo3_src directory.
> 
> Here is a fix with v3.
> 
> Xavier Perseguers wrote:
>> Hi,
>>
>> This is an SVN patch request.
>>
>> Type: Bugfix in DBAL with a minor update in Core
>>
>> Bugtracker references:
>> http://bugs.typo3.org/view.php?id=5120
>> http://bugs.typo3.org/view.php?id=8915
>>
>> Requires:
>> RFC #10411
>>
>> Branches: trunk
>>
>> Problem:
>> When trying to show the "Who is online" list (from User Admin / 
>> (function menu)
>>
>> Solution:
>> Use an INNER JOIN instead of an implicit CROSS JOIN to link tables 
>> be_sessions and be_users.
>>
>> Additionally, take into account limitation of the Core parser and 
>> reverse the comparison operator and remove extra useless parentheses.
>>
>> This implies that Core's SQL parser is able to parse more than 1 join 
>> and as such that patch from RFC #10411 gets committed.
>>
>> Cheers
>>
> 
> 


-- 
Xavier Perseguers
http://xavier.perseguers.ch/en

One contribution a day keeps the fork away