[TYPO3-core] RFC #12426: Code cleanup: Reports: Hard-coded strings for collections in status reports

Steffen Kamper info at sk-typo3.de
Sun Nov 1 20:52:42 CET 2009


Hi,

Francois Suter schrieb:
> Hi,
> 
>> imho the naming is unlucky:
>> collection_typo3_system
>>
>> i would name them like status_typo3_system etc.
> 
> I did that to differentiate these strings from all the others, because 
> they represent collections of statuses. But I can change them if you 
> think this is not a good idea.
>
my concern is that you should get an idea when looking to the labels 
from name. Collecting means all and nothing ;)

> Apart from that, forget about the first version of the patch, I 
> completely overlooked the "status" subfolder, which contains classes 
> full of hard-coded strings :-(
> 

ok - waiting for your update ;)

vg Steffen


More information about the TYPO3-team-core mailing list