[TYPO3-core] RFC: #11019: User Setup Rewrite #4

[Rupert Germann]

hi Steffen,

I found another thing that's not working correctly in v8:
the disabled options in the startup module selector doesn't show up anymore.

I'd be interested in what is different between your src and mine so that svn
diff produces different patches.

attached is a diff for index.php showing the differences between v7 and v8

 diff -u -B -w index.php_v7 index.php > 11019v7-v8.diff

greets
rupert



Christian Kuhn wrote:
> Hey Steffen,
> 
> all in all this patch looks pretty good to me and is a great improvement.
> 
> here is a formal +1 on reading and testing, if these minor things are
> fixed:
> 
> 
> + // save all submitted values if they are no array (arrays are with
> table=be_users) and exists in $TUS[columns]
> 
> There is no var $TUS, please improve comment (nitpicking)
> 
> 
> 
> The password change doesn't work, you messed up password and password1
> 
> 
> 
> +    * renders the data for all tabs in the user setup and returns
> +    * everything that is needed with tabs and dyntab menu
> +    *
> +    * @param   $data   a multi-dimensional array that will be converted
> to table contents
> +    * @param   $tabLabel   the label that is put on top of the tab array
> +    * @return  ready to use for the dyntabmenu itemarray
> +    */
> +   function renderUserSetup() {
> 
> Please fix phpdocs (arguments don't exist), and make it a protected
> function (same for function getLabel)
> 
> 
> 
> +           <label index="enableFlashUploader">Enable Flash Uploader
> (requires Flash 9+)</label>
> 
> This is superluous, the label already exists.
> 
> 
> 
> 
> Thanks for great work
> Christian