[TYPO3-core] RFC #6215: [Bug]: class.tslib_menu.php->getBeforeAfter might create bad html

[Christian Kuhn]

Hey Nabil.

Nabil Saleh wrote:
>> Solution:
>> space added
> But missed another space so here comes the hopefully final patch and a
> testmenuconfig. Image is taken from pageresources so you have to
> upload/reference an image there on a page in the menu to test.


Problem: Missing whitespace before "border" attribute.

Attached a new patch to make those lines a bit more readable, the
whitespace settings are now obvious.

+1 on reading and testing.


Cheers
Christian




TS testcases I played with:


config.xhtml_cleaning = none

page.10 >
page.10 = COA
page.10 {

  # test before img
  1 = HMENU
  1.special = rootline
  1.special.range = 0 | -2
  1.1 = TMENU
  1.1 {
    wrap = <ul>|</ul>
    NO.wrapItemAndSub = <li>|</li>
    NO.beforeImgLink = 1
    NO.beforeImg = fileadmin/path_to_some_img.png
  }

  # test before and RO img
  2 < .1
  2.1 {
    NO.RO = 1
    NO.beforeROImg = fileadmin/path_to_some_other_img.png
  }

  # test before and RO img and additional param
  3 < .2
  3.1 {
    NO.beforeImgTagParams =foo="bar"
  }
}
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 6215_03.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090530/b236e68d/attachment-0001.txt