[TYPO3-core] RFC #11154: calls to deprecated function makeInstanceClassName in core

[Franz Koch]

Hi Steffen,

> i have problems with the or-operator. It should behave this way:
> 
> config.incT3Lib_htmlmail = 1:
> send HTML if isHTMLContent === true, otherwise send plain with strip_tags
> config.incT3Lib_htmlmail = 0 or not set:
> send plain always
> 
> With your "or" isHTMLContent is first priority
> 
> So the check should be:
> $HTMLallowed = 
> isset($GLOBALS['TSFE']->config['config']['incT3Lib_htmlmail']) ? 
> intval($GLOBALS['TSFE']->config['config']['incT3Lib_htmlmail']) : false;
> 
> and the conditions:
> if (!$HTMLallowed) {
>     $adminContent = $this->isHTMLContent($adminContent) ? 
> strip_tags($adminContent) : $adminContent;
>     $admMail = $this->cObj->sendNotifyEmail(...);
> } else {
>     if ($this->isHTMLContent) {
>         sendHTMLMail
>     } else {
>         sendNotifyEmail
>     }
> }

Sorry, but I don't see a difference in my OR version with you're 
version. My version:
"If it's no HTML content or if HTMLmail is not allowed send plaintext."

Your version:
"If HTMLmail is not allowed or (if it's allowed but) it's no HTML 
content send plaintext."

The result is totally the same, only that my OR-version is preventing 
redundant code for sending the plaintext mail.
-- 
kind regards,
Franz Koch

---------------------------------------------------
PayPal-Account: 'paypal _at_ elements-net _dot_ de'
---------------------------------------------------