[TYPO3-core] RFC #9994: Bug: ereg_replace is deprecated in PHP 5.3 alpha3

Karsten Dambekalns karsten at typo3.org
Fri May 22 09:29:03 CEST 2009


Hi.

On 22.05.2009, at 00:01, Steffen Kamper wrote:
> this patch doesn't work for some cases. TV shows highlighted xml,  
> which
> is broken now:
> Warning: preg_split() [function.preg-split]: Unknown modifier 'l' in
> /var/www/typo3-svn-semantic/t3lib/class.t3lib_parsehtml.php on line  
> 357

Ok, $tags must be sent through preg_quote() there to quote  
backslashes, probably before the implode (so as to not quote pipe  
symbol).

> and no output of xml. Maybe the error is located before in
> class.t3lib_syntaxhl.php, i will investigate.

Thanks.

> But it shows that the conversion isn't that trivial and this patch  
> changes
> too much classes at once.


It is a huge one, but there is no other way: If you change only a part  
of the code, you still drown in PHP warnings. If you change all at  
once, you must be sure to check every part of the system afterwards  
(impossible for a (single) developer).

So, having the change in the code before the broad testing in public  
(wishful thinking?) is the best way...

Regards,
Karsten
-- 
Karsten Dambekalns
Gimme Five!
http://typo3.org/gimmefive




More information about the TYPO3-team-core mailing list