[TYPO3-core] FYI24: #11124: Validation issue: End tag for "br" omitted, but OMITTAG NO was specified in typo3/mod/tools/em/class.em_index.php

Ernesto Baschny [cron IT] ernst at cron-it.de
Wed May 20 17:27:27 CEST 2009


Patrick Broens wrote: on 20.05.2009 09:53:

> Problems:
> Although we once decided to switch to XHTML 1.0 Transitional, there are
> some errors with "br" tags.
> * there are still a lot of "br" tags in the core where no ending is
> defined for the singleton tag.
> * there are some "br" tags where the slash is next to the "r" without
> the space between the "r" and the slash.
> * uppercase tags
> 
> Solution:
> Change these tags with the proper markup.
> 
> Notes:
> I consider this a no-brainer, as it does not change any functionality,
> only proper markup. Please object if you don't agree, otherwise this
> patch will be committed after 24 hours.

I think one big patch would have been enough. You can always "revert"
just some parts of it if something makes trouble.

But these kind of changes:

-		$content.= '<label for="_lookUp">Look up:</label> <input type="text"
id="_lookUp" name="_lookUp"
value="'.htmlspecialchars($this->lookUpStr).'" /><input type="submit"
value="Search"/><br/><br/>';
+		$content.= '<label for="_lookUp">Look up:</label> <input type="text"
id="_lookUp" name="_lookUp" value="' .
htmlspecialchars($this->lookUpStr) . '" /><input type="submit"
value="Search"/><br /><br />';

seem not needed. Both are valid XHTML. The space before the "/" is AFAIK
optional. Same goes for the <hr/> => <hr /> corrections.

Cheers,
Ernesto


More information about the TYPO3-team-core mailing list