[TYPO3-core] RFC: #10994: allow using custom adapter for extJs

Martin Kutschker masi-no at spam-typo3.org
Tue May 19 22:01:43 CEST 2009


Steffen Kamper schrieb:
> Hi Masi,
> 
> Martin Kutschker schrieb:
>> Steffen Kamper schrieb:
>>> Hi,
>>>
>>> Martin Kutschker schrieb:
>>>> You forgot to add a default in the switch for the ext-base adapter.
>>> do you think it's needed? Default adapter is set in initialisation of
>>> the var.
>>
>> Sorry, I have overlooked that one.
>>
> 
> np. I added the constants and an inline comment which makes this clear.
> The constants make it easy to choose an adapter, like
> template::EXTJS_ADAPTER_JQUERY
> 
> So, are you +1 with this? Only one is missing.

+1 from reading, but please check the indenting of the lines with
"const" before committing.

Masi


More information about the TYPO3-team-core mailing list