[TYPO3-core] RFC: #11019: User Setup Rewrite #4

[Steffen Kamper]

Hi Rupi,

Rupert Germann schrieb:
> hi Steffen,
> 
> I had a look to your v2 patch and have some remarks:
> 
> +       protected function checkAccess($level) {
> +               if ($level = 'admin') {
> +                       return $GLOBALS['BE_USER']->isAdmin(); 
> +               }
> +       }
> 
> this will always be TRUE ;-)
>

sure, was a typo

> and as Olly said: please move the $GLOBALS[...]-> changes to another patch.
> Or do them at least consequently - and not like in this line:
> 
> <input type="submit" name="data[setValuesToDefault]" value="'
> $LANG->getLL('setToStandard').'" onclick="return confirm(\''
> $GLOBALS['LANG']->getLL('setToStandardQuestion').'\');" />'
>  

I reverted now all $GLOBALS in functions having globals defined. Will do 
in seperate cleanup.

vg Steffen