[TYPO3-core] RFC: #11019: User Setup Rewrite #4

[Oliver Hader]

Hi Steffen,

Steffen Kamper schrieb:
> Hi,
> 
> This is SVN patch request.
> 
> Type: Bugfix
> 
> Branches: trunk
> 
> BT reference: http://bugs.typo3.org/view.php?id=11019
> 
> Benni already started top use a configuration array for user settings
> with a TCA-like array.
> 
> This is the next step using a real configuration array in
> $GLOBALS['TUS'], where TUS stands for TYPO3 User Settings
> 
> This allows to manipulate the render of settings without hook like you
> can do it with TCA and simplify it.

Some comments on reviewing:
* before using another abbreviation in a new global variable, I'd like
to a registry singleton that delivers the same configuration by e.g.
"$userSettings = t3lib_Registry::getUserSettings();"
* "LANG:" introduces a new key that does not really tell, where to get
the label from
* please use e.g. $backendUserData instead of $BE_USER_data
* instead of using $GLOBALS['TUS']['columns'][$fieldname] multiple times
in the same method creat a copy of that information to e.g.
$fieldSettings and use that one
* please use proper PHPdoc comments and protected/public definitions on
methods (e.g. "function simulateUserOptions()")
* using e.g. $GLOBAL['LANG'] is not required in global context
! please keep functional changes separated from functional changes (e.g.
converting all $BE_USER to $GLOBALS['BE_USER'] would go to a separate patch)

Thanks!

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3