[TYPO3-core] RFC #11016: Implement RSA authentication for BE and FE

Martin Kutschker masi-no at spam-typo3.org
Sun May 3 14:36:09 CEST 2009


Oliver Hader schrieb:
> Hi Dmitry,
> 
> Dmitry Dulepov schrieb:
>> Hi!
>>
>> Oliver Hader wrote:
>>> I just had a quick run over the files and it looks good so far. I
>>> discovered some minor things with naming and PHPdocs. Furthermore the
>>> factory methods seem to be strict as for example the storage factory
>>> implements a "singleton storage". However for this specific case it's
>>> okay...
>>>
>>> What should I do about changes? Are the patches you posted here based on
>>> the Forge project? If they are, I could post the diff to the latest SVN
>>> revision.
>> Thanks for looking at it! May be you can tell what you propose to change and we discuss it here? I am ok to make changes but I may need to explain why I did some things one way and not the other :)
>>
>> For example, I used factories because I like this design pattern. I used it for ages and it allows to hide the selection logic inside one place.
> 
> Ha, well... I know, how factories are used.
> 
> +1 on testing
> 
> Since Ingmar and Andi did a positive review some days ago, I'd say that
> you can commit this new feature to SVN Trunk. I'm going to post my
> suggestions as a patch to the current version later on.

Right. Go an commit it.

Masi


More information about the TYPO3-team-core mailing list