[TYPO3-core] RFC: #10741: Create version of page crashes in Cache

[Steffen Müller]

Hi.

On 30.03.2009 10:37 Steffen Kamper wrote:
> here is the patch according to the changes in FLOW3. I didn't included
> the other changes from Robert which doesn't belong to this issue.
> 

+1 after reading and testing, with one minor cosmetic objection:

I don't like the pattern, since it uses unnecessary escape sequence for
the dash: \-

+	const PATTERN_ENTRYIDENTIFIER = '/^[a-zA-Z0-9_%\-&]{1,250}$/';

The dash is the only character which needs to be escaped in classes. But
even this escape sequence can be avoided by putting the dash at the very
beginning of the class:

+	const PATTERN_ENTRYIDENTIFIER = '/^[-_%&a-zA-Z0-9]{1,250}$/';

So we'd have no escaping at all and less confusion for the unexperienced
regex people.

Is it worth to propose this upstream for FLOW3?

-- 
cheers,
Steffen

http://www.t3node.com/