[TYPO3-core] FYI24: Fix issue #10713: Refactor tslib_gifBuilder::calcOffset()
Oliver Hader
oliver at typo3.org
Thu Mar 19 00:06:58 CET 2009
FYI: Committed to SVN Trunk (rev. 5209)
olly
Oliver Hader schrieb:
> This is an announcement of a SVN change that will be committed in 24 hours.
>
> Type: Feature/Cleanup
>
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=10713
>
> Branch: Trunk
>
> Problem:
> The method tslib_gifBuilder::calcOffset() takes strings like
> "123,10.h+13+20.h" and calculates the values. However, it can be handy
> to have this calculation available for each single segment of that list.
>
> Solution:
> Refactor tslib_gifBuilder::calcOffset() to be able to reuse calculation
> functions on single segments like "10.h+13+20.h" and move that
> functionality to a new method called calculateValue().
>
> Notes:
> I removed the intval() calls at the modulo and division operations since
> the given value is already an integer. This cleanup is part of RFC #10666.
>
> olly
--
Oliver Hader
TYPO3 Release Manager 4.3
More information about the TYPO3-team-core
mailing list