[TYPO3-core] RFC: Bug #10099: Use TYPO3_DB->exec_SELECTcountRows() to determine the number of rows
Oliver Hader
oliver at typo3.org
Mon Mar 9 11:03:49 CET 2009
Hi Michael,
Michael Stucki schrieb:
> Hi Olly,
>
> I reviewed the patch without testing yet, but it seems almost perfect to
> me. Great work!
>
> One thing though: In tslib/class.tslib_fetce.php, you have added an
> intval() statement to the end of the $doublePostField check. I looked at
> the code and the value should always come from hexdec, which means
> "number". So the addition will most likely not hurt, but I can't say for
> sure. What I would like in any case is that this change (and more if I
> overlooked any others) is moved into a separate commit.
>
> +1 after that part is removed.
Thanks! I'm fine with removing the intval() from the patch...
olly
--
Oliver Hader
TYPO3 Release Manager 4.3
More information about the TYPO3-team-core
mailing list