[TYPO3-core] RFC #9823: Save and close closes without saving
Jeff Segars
jsegars at alumni.rice.edu
Sun Mar 8 15:55:48 CET 2009
Tobias Liebig wrote:
> Jeff Segars schrieb:
>> Jeff Segars wrote:
>>> Tobias Liebig wrote:
>>>> Susanne Moog schrieb:
>>>>> Tobias Liebig schrieb:
>>>>>> This is SVN patch request.
>>>>>>
>>>>>> Type: Bugfix
>>>>>>
>>>>>> Branches: trunk, 4_2
>>>>>>
>>>>>> BT reference: http://bugs.typo3.org/view.php?id=9823
>>>>>>
> ...
>>
>> +1 on reading and testing in FF3 with a few tiny nitpicks and a
>> question :)
>>
>> * I noticed the spacing is a little inconsistent in the third hunk.
>> Attached an updated patch using tabs instead of spaces.
>> * I also noticed that the form variable is used for this.saveButtons
>> but not for the event observer when the form is submitted. For
>> consistency, I went ahead and removed the form variable and assigned
>> this.saveButtons directly.
>> * Susanne, did you (or anyone else) have a chance to test in IE?
>>
>> Thanks,
>> Jeff
>>
>
> thanks Susanne and Jeff for testing and the small cleanup changes.
>
> i've tested again the new patch and commited it in rev 5143
>
> regards
> tobias
>
Woohoo...first commit! Congrats Tobi!
More information about the TYPO3-team-core
mailing list