[TYPO3-core] RFC #9823: Save and close closes without saving

[Jeff Segars]

Jeff Segars wrote:
> Tobias Liebig wrote:
>> Susanne Moog schrieb:
>>> Tobias Liebig schrieb:
>>>> This is SVN patch request.
>>>>
>>>> Type: Bugfix
>>>>
>>>> Branches: trunk, 4_2
>>>>
>>>> BT reference: http://bugs.typo3.org/view.php?id=9823
>>>>
>>>> Problem:
>>>> The underlying textarea was not updated when using the Save+Close
>>>> Button. Bug was introduced since #8830
>>>>
>>>> The attached patch observed the form submit event and takes care of
>>>> updating the textarea before submitting the form.
>>>>
>>>
>>> +1 by testing (note: when using ff3 you may have to manually clear the
>>> browser cache to make it work)
>>>
>>> Regards,
>>>
>>> Susanne
>>
>> Thanks Susanne for testing!
>> We need another +1 (from a core dev) to get this into alpha2...
> 
> I'll get to this tomorrow if no one else does before then.  Started 
> reading yesterday and got distracted :)

+1 on reading and testing in FF3 with a few tiny nitpicks and a question :)

* I noticed the spacing is a little inconsistent in the third hunk. 
Attached an updated patch using tabs instead of spaces.
* I also noticed that the form variable is used for this.saveButtons but 
not for the event observer when the form is submitted.  For consistency, 
  I went ahead and removed the form variable and assigned 
this.saveButtons directly.
* Susanne, did you (or anyone else) have a chance to test in IE?

Thanks,
Jeff


-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch_9823_saveandclose_v2.diff
Type: application/pgp-keys
Size: 3183 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090307/2de70e29/attachment.key