[TYPO3-core] RFC: #2178: template::getTabMenu doubles ampersands

[Stefano Kowalke]

Hi,

this is a SVN patch request.

Type: Bugfix

Bugtracker references:
http://bugs.typo3.org/view.php?id=2178
http://bugs.typo3.org/view.php?id=3093

Branches: 4.2, trunk

Problem:
The function: template::getTabMenu produces following HTML output as
example: index.php?&id=1&tab=1

Additional Info:
The problem is template::getTabMenu() generates the url, and passes it
through "htmlspecialchars". Then calls template::getTabMenuRaw(), which
will then render the A-tag, but will pass the url again through
htmlspecialchars. My comment from on 0000772 from 10.11.05 17:00 you can
see that if we follow my 4-step instructions, we need to: generate the
URL in its raw mode in getTabMenu() and then just pass it through
htmlspecialchars right before generating the A-tag.

So the fix would be to remove the "htmlspecialchars()" call in
getTabMenu(), leaving it just in getTabMenuRaw().


Solution:
Dont pass the URL to htmlspecialchars function in template.php.


Cheers
Stefano
-- 
Seit dem 1.1.2008 werden Daten zu jeder E-Mail verdachtsunabhängig gespeichert! 
Weitere Informationen: www.vorratsdatenspeicherung.de
GPG-ID: 0x2B08936D
Key-Fingerprint: 7F31 BCF0 70C0 B3B1 1235 07E9 1777 D7A0 2B08 936D
-------------- next part --------------
A non-text attachment was scrubbed...
Name: template.php.diff
Type: text/x-diff
Size: 655 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090306/b38dd90e/attachment.diff