[TYPO3-core] RFC #10497: Mark t3lib_div::makeInstanceClassName() as deprecated

Oliver Hader oliver at typo3.org
Mon Mar 2 21:57:40 CET 2009


Hi Ingo,

Ingo Renner schrieb:
> Branches: trunk
> 
> BT reference: http://bugs.typo3.org/view.php?id=10497
> Related to: http://bugs.typo3.org/view.php?id=10454
> 
> Problem:
> t3lib_div::makeInstanceClassName() allows to circumvent the check for
> t3lib_Singleton in t3lib_div::makeInstance(). t3lib_div::makeInstance()
> is now capable of passing arguments to constructors (see 0010454).

+1 on reading and testing

However, before committing this to Trunk we have to make sure, that
calls that are not really visible (like e.g. AJAX calls) and that are
using deprecated calls work as before. This could be done with the error
and exception handling or (simpler) with a property in TYPO3_CONF_VARS
to disable the PHP notices in t3lib_div concerning calls to deprecated
functions.
Since the ajax.php was fixed as well with this patch, I could not see
any problems on AJAX calls in core while testing.

Setting the mentioned method to "deprecated" does not break anything. It
just shows a notice that a deprecated method is used that will be
removed two releases later. Whether this information shall be shown or
not can be defined in php.ini and productive websites should not show
warnings or notices.
t3lib_div::makeInstanceClassName() is not the only method that is marked
as deprecated an will produce an accordant entry in the deprecation log.

olly
-- 
Oliver Hader
TYPO3 Release Manager 4.3


More information about the TYPO3-team-core mailing list