[TYPO3-core] RFC #10497: Mark t3lib_div::makeInstanceClassName() as deprecated

[Ingo Renner]

Hi *,

This is a SVN patch request

Type: tweak

Branches: trunk

BT reference: http://bugs.typo3.org/view.php?id=10497
Related to: http://bugs.typo3.org/view.php?id=10454

Problem:
t3lib_div::makeInstanceClassName() allows to circumvent the check for 
t3lib_Singleton in t3lib_div::makeInstance(). t3lib_div::makeInstance() 
is now capable of passing arguments to constructors (see 0010454).

Thus t3lib_div::makeInstanceClassName() is not needed anymore and should 
be avoided due to the missing check for t3lib_Singleton.


Solution:
mark t3lib_div::makeInstanceClassName() as deprecated, remove all calls 
to it in the core and replace them by calls to t3lib_div::makeInstance()


Notes:
Whith the attached patch everything should work as before.
There's one call to makeInstanceClassName() left which can be removed 
after we inlcude the autoloader.



all the best
Ingo

-- 
Ingo Renner
TYPO3 Core Developer, Release Manager TYPO3 4.2

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: deprecate_makeInstanceClassName.diff.txt
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090302/e7d225ea/attachment.txt