[TYPO3-core] RFC #10523: New install tool colors, matching t3skin

[Daniel Krupke]

Hi Susanne,

this one is great! With your work the install tool layout is going the
right way. Patch is ok by reading and testing, but I think there are
some small issues left.

In IE and Opera section "8: phpinfo()" always destroys layout, because
there is a long line with nowrap that widens table width extremely.
Setting ".v {width: 700px; max-width: 700px;}" in css file solves this
issue in IE and Opera for me.

You introduced classes "error" and "note", so why do you use class
"color4" instead of a warning class like "warning" in "10: About"?

Login screen looks a bit too stretched (see attached png) and IMHO the
class "error" is too much at this point. You could use the previously
mentioned class "warning" for that.

So long,
Daniel Krupke

2009/3/1 Susanne Moog <typo3 at susannemoog.de>:
> This is a SVN patch request.
>
> Type: Feature
>
> Branches:
> trunk
>
> BT reference:
> http://bugs.typo3.org/view.php?id=10523
>
> Problem:
> As the new default TYPO3 skin is t3skin the install tool should match
> that instead of displaying the old colors.
>
> Solution:
> Attached is a patch that replaces the colors in install tool code with
> css classes and adds a stylesheet to display the new colors.
> Additionally to changing the colors it adjusts the width of the install
> tool to better match current screen resolutions (dynamic scaling to 80%
> screen width, with a max-width for readability).
>
> Note:
> As I only have Ubuntu and a Wine IE6 I can't really test in IE (or: I
> can't debug as the developer toolbar won't work) so it would be
> especially important to have some IEx tester/debugger.
>
> I have successfully tested the patch in FF3 and Opera9.63.
>
> (Attached a cropped screenshot how it looks like)
>
> Regards,
>
> Susanne
>
> _______________________________________________
> Before posting to this list, please have a look to the posting rules
> on the following websites:
>
> http://typo3.org/teams/core/core-mailinglist-rules/
> http://typo3.org/development/bug-fixing/diff-and-patch/
> _______________________________________________
> TYPO3-team-core mailing list
> TYPO3-team-core at lists.netfielders.de
> http://lists.netfielders.de/cgi-bin/mailman/listinfo/typo3-team-core
>



-- 
newmedia.solutions sk | Krupke & Siemon GbR
Daniel Krupke
Rosenbergstr. 28
70174 Stuttgart
Mobil +49 177 / 642 74 92
info at newmedia-solutions.de
www.newmedia-solutions.de
ICQ# 51473103
-------------- next part --------------
A non-text attachment was scrubbed...
Name: install_tool_login.png
Type: image/png
Size: 17481 bytes
Desc: not available
Url : http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090301/ea3da2c9/attachment-0001.png