[TYPO3-core] RFC: #10853: [Feature] New Multimedia CE

[Steffen Kamper]

Hi,

here is a new version taking comments into account

>> ===== helper functions =====
>>
>> I love "readFlexformIntoConf", this could be used for so many of my 
>> plugins. However, I don't like that it is merged into a parameter.
>>
>> I would rather have a return value that is conf, and then we can merge 
>> the result with the $conf var. right?
>>
>>   $ffConf = $this->flexform2array($flexData);
>>   $conf = array_merge_recursive($ffConf, $conf);
>>
>>
looking again this is not possible because of recursive call of 
function. Also the complexity of the conf for Media doesn't allow a 
simple merge.
When you use it you can do it "as" a merge by giving your conf:
$this->cObj->readFlexformIntoConf($this->cObj->data['pi_flexform'], 
$this->conf);



>> Well, the parameter $recursive is "0" by default, although it's 
>> boolean. Then you have a $recursive === 0 (which is a type comparison 
>> as well), so this is either wrongly coded or wrongly documented :)
>>
fixed

>> What about "arrayKeyMap"? This should not stay in tslib_content as 
>> it's very generic. I'd also rename it, as array_map() is something 
>> else :). "remapArrayKeys" or something like that, in t3lib_div.
>>
>>
now t3lib_div::remapArrayKeys
> 

>> ====== TS constants =======
>>
>> +    # cat=content/cMedia; type=int+; label= Video Media Width: define 
>> the default width for the media-object   +  videoPlayer = 
>> typo3/contrib/flashmedia/flvplayer.swf
>>
>> +    # cat=content/cMedia; type=int+; label= Audio Media Width: define 
>> the default width for the media-object
>> +  audioPlayer = typo3/contrib/flashmedia/player.swf
>>
>>
>> Define the default width of the player?
>>
hm - it's there: 
defaultVideoWidth/defaultVideoHeight/defaultAudioWidth/defaultAudioHeight

> 
>> ====== MediaItems Hook ======
>>
>> +if (is_array 
>> ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/hooks/class.tx_cms_mediaitems.php']['customMediaRender'])) 
>> {
>> +    foreach 
>> ($GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/hooks/class.tx_cms_mediaitems.php']['customMediaRender'] 
>> as $classRef) {
>> +        $hookObj = &t3lib_div::getUserObj($classRef);
>> +        $conf['file'] = $url;
>> +        $content = $hookObj->customMediaRender($renderType, $conf);
>> +    }
>> +}
>>
>> Please add the $mode to the $conf variable as well.
>>
done

new applyable patch is attached.

vg Steffen
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: new_media_v18.diff
Url: http://lists.netfielders.de/pipermail/typo3-team-core/attachments/20090628/93755fc8/attachment-0001.txt