[TYPO3-core] RFC #8400 Fixed: Bug: "real_uid" not added when using "overrideId"

[Benjamin Mack]

Hey Markus,

are you gonna update your patch soon?

Thanks for your work!

All the best,
Benni.

On 01.05.2009 14:19 Uhr, Markus Deckmann wrote:
> Hi Patrick,
>
>> We don't want to disencourage you sending in patches, but you have to do
>> it the proper way. Take a look at the comments from Xavier and have a
>> look at your patch compared to patches available in this list.
>
> No problem...at the time I working on a large project and found another
> bug in my patch. I will retry produce a patch in the next time and send
> it again to list.
>
>
>> As you can see, your patch is throwing away everything (from the
>> Copyright notice till the XClass part, so from top till bottom) in this
>> class, and adds all lines again. That's no proper patch file. Only the
>> lines which have been changed/removed/added, should be visible in your
>> patch (probably including only some lines above or after it), which is
>> not the case.
>>
>> Hint: read http://typo3.org/development/bug-fixing/
>
> Thx for all the hints, I will read it before I retry create a patch.
>
> Bye Markus