[TYPO3-core] RFC #11379: Info/Modify uses hardcoded texts

Martin Kutschker masi-no at spam-typo3.org
Tue Jun 23 16:55:42 CEST 2009


Christopher Stelmaszyk schrieb:
> +		<languageKey index="default" type="array">
> +			<label index="editField">Edit field</label>
> +			<label index="delete">Delete:</label>
> +			<label index="toTop">To top:</label>
> +			<label index="file">File:</label>
> +			<label index="editFile">Edit file</label>
> +			<label index="title">Title:</label>
> +			<label index="sitetitle">Sitetitle:</label>

Don't we have a common language file for these (or other labels) in your
patch?

> +			<label index="SentenceFilesizePartOne">Filesize exceeded</label>
> +			<label index="SentenceFilesizePartTwo">KBytes.</label>
> +			<label index="SentenceToLargePartOne">Files larger than</label>
> +			<label index="SentenceToLargePartTwo">KBytes are not allowed to be 
> edited.</label>

Please use sprintf() rather than a concatenation of strings. This allows
for localization to languages where the order of the variable parts of
the sentence are different (see PHP docs for details).

Masi


More information about the TYPO3-team-core mailing list