[TYPO3-core] RFC: #10791: Performance improvement: Skip cHash check if page is already non-cached

Michael Stucki michael at typo3.org
Tue Jun 23 14:12:00 CEST 2009


Hi Ingmar,

> I wonder why the function is called at all then...
> 
> I would prefer not calling it if it isn't necessary, instead of this
> early return.

I would prefer if index_ts.php contains as little logic as possible and 
just calls one method after each other. This is how it is already done 
in index_ts/tslib_fe, and I pretty much like to keep it that way.

- michael

> Michael Stucki schrieb:
>> This is a SVN patch request.
>>
>> Type: Bugfix / performance improvement
>>
>> Problem:
>> TYPO3 compares the cHash parameter against the computed checksum of all
>> GET parameters. In case the checksum does not match,
>> $TSFE->set_no_cache() is triggered.
>>
>> Actually this is not needed if $TSFE->no_cache is already set.
>>
>> Solution:
>> Return if $TSFE->no_cache is already set.
>>
>> Branches: Trunk only
>>
>> Bugtracker reference: http://bugs.typo3.org/view.php?id=10791
>>
>> - michael
>>
> 
> 


-- 
Use a newsreader! Check out
http://typo3.org/community/mailing-lists/use-a-news-reader/


More information about the TYPO3-team-core mailing list