[TYPO3-core] FYI72: #11145: Starttime/endtime is not taken into account when caching

Rupert Germann rupi at gmx.li
Tue Jun 9 08:49:13 CEST 2009


hi dmitry

Dmitry Dulepov wrote:
> I did not test it but I have a question. Will this new version work
> correctly if a plugin sets caching value manually while executing as a
> part of the page rendering?

I'm not shure what you mean with "sets caching value" - cache content or
cache lifetime? 
if there's something special about the line "$now = 60*(time()/60 - 1);"
that I didn't get until now, please enlighten me - or commit the patch with
this line - I don't really care.
But then you should remove "...(do not polute MySQL cache!)" from the
comment, because with  60*(time()/60 - 1) the time value in the query will
change every second == poluting the query cache with lots of entries.

but however: there should be no direct calls to time() in core classes.
use EXEC_TIME or ACCESS_TIME.

greets
rupert





More information about the TYPO3-team-core mailing list