[TYPO3-core] RFC: #11260: Feature: Speed up xml2array by adding a two level cache
Rupert Germann
rupi at gmx.li
Sun Jun 7 23:39:22 CEST 2009
hi,
FYI: committed the suggested line below (without the parse error *g*) to
trunk
greets
rupert
Oliver Hader wrote:
> Hi Masi,
>
> Martin Kutschker schrieb:
>> I think there is a problem with the identifier:
>>
>> $identifier = md5($string . $NSprefix . $reportDocTag);
>>
>> It's meant to be a boolean, but you PHP coders ;) So I suggest to
>> normalize this parameter. Choose one of the suggestions:
>>
>> md5($string . $NSprefix . ($reportDocTag ? '1' : '0');
>> md5($string . $NSprefix . ($reportDocTag ? 'true' : 'false');
>> md5($string . $NSprefix . ($reportDocTag == true));
>> etc.
>
> Agreed, it does not hurt to normalize this to 0/1...
>
> olly
More information about the TYPO3-team-core
mailing list