[TYPO3-core] RFC: #10175: Duplicated values in localconf.php (typo3conf)

[Rupert Germann]

hi,

tested Susannes version against trunk.

yes, the patch works, but I have no good feeling with adding
such "program-around-possible-sideeffects-from-earlier-bugs-code" to the
core.
At least not without proper commenting.
eg.:
// due to a bug in the update wizard (fixed in TYPO3 4.1.7) it is possible
that $TYPO3_CONF_VARS['SYS']['compat_version'] was enclosed by "" (double
quotes) instead of the expected '' (single quotes) when is was written to
localconf.php. The following code was added to make sure that values with
double quotes are updated, too.


but since I see that this issue can be kind of anoying when updating older
sites I give it an unwilling +1 (with the comment)

greets
rupert




Susanne Moog wrote:
> Hi,
> 
> Stefano Kowalke schrieb:
>> Hi,
>> 
>> this is an SVN patch request
>> 
>> Branches: 4.1, 4.2, trunk
>> 
>> Type: Bugfix
>> 
>> BT reference: http://bugs.typo3.org/view.php?id=10175
> 
>> Solution:
>> Make the installer tolerance for finding arrays with double quotes and
>> replace the double quotes with single quotes.
> 
> +1 by testing (against trunk)
> 
> The patch did not apply cleanly, so attached is a version that works for
> me.
> 
> Regards,
> 
> Susanne