[TYPO3-core] RFC Bug #10597: Admin panel is not available anymore when extension fe_edit is not installed

[Jeff Segars]

Oliver Hader wrote:
> This is an SVN patch request.
> 
> Type: Bugfix
> 
> Bugtracker references:
> http://bugs.typo3.org/view.php?id=10597
> 
> Branch: Trunk
> 
> Problem:
> When the extension fe_edit (extracted functionality of frontend to
> separate system extension) is not installed the admin panel
> (config.admPanel=1) is not displayed anymore.
> 
> The admin panel should work without frontend editing since the admin
> panel is not only about content editing - but more about general
> information of the current page rendering.
> 
> Solution:
> Move the adminpanel from the system extension "fe_edit" to
> t3lib/class.t3lib_adminpanel.php. Furthermore move parts of the frontend
> editing to the new class since actually that is the correct place.
> 
> *Notes*:
> How to use the patch
> 1) svn mv typo3/sysext/fe_edit/view/class.tx_feedit_adminpanel.php
> t3lib/class.t3lib_adminpanel.php
> 2) apply the attached patch
> 
> olly
> 

I think we may need two small followups on this patch...

#1 - t3lib_frontendedit still references $this->extGetFeAdminValue() in 
one place.  This should now be $BE_USER->adminPanel->extGetFeAdminValue().

#2 - t3lib_tsfebeuserauth initializes frontend editing, but as part of 
that checks that fe_edit is loaded.  This means frontend editing is not 
initialized when feeditadvanced is installed isntead. I think we can 
remove the check for any extension and still be OK.