[TYPO3-core] RFC #0011512: replace while(list()...) by foreach in the TYPO3 core part 1
Steffen Kamper
info at sk-typo3.de
Thu Jul 30 17:47:49 CEST 2009
Hi Rupi,
+1 by reading and testing (testing means all worked like before as i
could see)
Some nitpicks (linenumbers are the one from diff file):
Line 88, 394, 456 you renamed varname of value
Line 799 you renamed varname of key
Even if they are not used later (what you don't know while reading diff)
i would use same varname as before.
If you introduce new varname for value please use $value instead of $v
If you change this while commit i'm fine.
vg Steffen
More information about the TYPO3-team-core
mailing list