[TYPO3-core] RFC #11602: Reset filter above the page-tree is not translatable

Christopher Stelmaszyk christopher at yahoo.de
Thu Jul 30 12:31:39 CEST 2009


Hi!

This is a SVN patch request.

Type: feature

Branches: trunk

BT reference:
http://bugs.typo3.org/view.php?id=11602

Problem:
If you search something in the page-tree, there is this small close-button 
near the filter (the "x"). If you hover over it, there should be the text 
"Reset filter".
But: This text is not visible in all browsers and it is hardcoded.

Solution:
1. Add the forgotten title-tag, so that the text is visible in all browsers.
2. Make it localizable.

Since the same code is present in the folder-tree too, the patch adapts this 
line there, too.

Kind regards

Christopher



Index: typo3/sysext/lang/locallang_core.xml
===================================================================
--- typo3/sysext/lang/locallang_core.xml	(revision 5735)
+++ typo3/sysext/lang/locallang_core.xml	(working copy)
@@ -19,6 +19,7 @@
 			<label index="labels.unknownUser">-Unknown-</label>
 			<label index="labels.showRecords">Show records</label>
 			<label index="labels.path">Path</label>
+			<label index="labels.resetFilter">Reset Filter</label>
 			<label index="labels.table">Table</label>
 			<label index="labels.upOneLevel">Up one level</label>
 			<label index="labels.expandTable">Expand table</label>
Index: typo3/alt_file_navframe.php
===================================================================
--- typo3/alt_file_navframe.php	(revision 5735)
+++ typo3/alt_file_navframe.php	(working copy)
@@ -233,7 +233,9 @@
 			// Setting up the buttons and markers for docheader
 		$docHeaderButtons = $this->getButtons();
 		$markers = array(
-			'IMG_RESET' => '<img' . t3lib_iconWorks::skinImg($GLOBALS['BACK_PATH'], 
'gfx/close_gray.gif', ' width="16" height="16"') . ' id="treeFilterReset" 
alt="Reset Filter" />',
+			'IMG_RESET' => '<img' . t3lib_iconWorks::skinImg($GLOBALS['BACK_PATH'], 
'gfx/close_gray.gif', ' width="16" height="16"') .
+			' id="treeFilterReset" alt="' . 
$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xml:labels.resetFilter') . 
'" ' .
+			'title="' . 
$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xml:labels.resetFilter') . 
'" />',
 			'CONTENT' => $this->content
 		);

Index: typo3/alt_db_navframe.php
===================================================================
--- typo3/alt_db_navframe.php	(revision 5735)
+++ typo3/alt_db_navframe.php	(working copy)
@@ -231,7 +231,9 @@
 			// Setting up the buttons and markers for docheader
 		$docHeaderButtons = $this->getButtons();
 		$markers = array(
-			'IMG_RESET'     => 
'<img'.t3lib_iconWorks::skinImg($GLOBALS['BACK_PATH'], 'gfx/close_gray.gif', 
' width="16" height="16"').' id="treeFilterReset" alt="Reset Filter" />',
+			'IMG_RESET'     => '<img' . 
t3lib_iconWorks::skinImg($GLOBALS['BACK_PATH'], 'gfx/close_gray.gif', ' 
width="16" height="16"') .
+			' id="treeFilterReset" alt="' . 
$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xml:labels.resetFilter') . 
'" ' .
+			'title="' . 
$GLOBALS['LANG']->sL('LLL:EXT:lang/locallang_core.xml:labels.resetFilter') . 
'" />',
 			'WORKSPACEINFO' => $this->getWorkspaceInfo(),
 			'CONTENT'       => $this->content
 		); 




More information about the TYPO3-team-core mailing list