[TYPO3-core] RFC #11027: Warning is issued when creating first template

[Rupert Germann]

hi xavier,

I'm quite shure that your patch is not needed anymore because #11285 should
fix this issue too.

the problem you described was caused by a tcemain action (saving a
tstemplate record) which called flushByTag() to clear a nonexisting
page_cache entry.

flushByTag() looked like this until #11285 was commited:

....
public function flushByTag($tag) {
     foreach ($this->findIdentifiersByTag($tag) as $entryIdentifier) {
         $this->remove($entryIdentifier);
     }
}

now it looks like this:

public function flushByTag($tag) {
        $GLOBALS['TYPO3_DB']->exec_DELETEquery(
                $this->cacheTable,
                $this->getListQueryForTag($tag)
        );
}
 
this works way faster and should fix also #11027, because
findIdentifiersByTag() is not called anymore.

greets
rupert



Xavier Perseguers wrote:

> Hi,
> 
> REMINDER #2
> 
> 
> Xavier Perseguers wrote:
>> Hi Benni,
>> 
>> Sorry for not having seen your message.
>> 
>>> isn't this a problem inside "exec_SELECTgetRows"?
>>>
>>> Shouldn't this return an array at any time?
>>>
>>> Citing t3lib_db.php
>>> ========
>>> $res =
>>> $this->exec_SELECTquery($select_fields,$from_table,$where_clause
$groupBy,$orderBy,$limit);
>>>
>>>
>>> if (!$this->sql_error())    {
>>>     $output = array();
>>> ========
>>>
>>> the $output is only an array if the SQL is not an error, right?
>> 
>> Right. I highly prefer fixing this to be consistent with other methods
>> (exec_SELECTcountRows for instance where the result var is initialized
>> at the beginning of the method)
>> 
>> Attached is another patch that fixes the issue in t3lib_db.php instead.
>> 
>> And this becomes a no-brainer I guess...
>> 
>> Thanks.
>> 
> 
>