[TYPO3-core] RFC Bug #11450: Install tool access check should take IPv6 loopback into account

Mario Rimann typo3-coding at rimann.org
Wed Jul 1 10:03:31 CEST 2009


Hi

Martin Kutschker schrieb:
> But the real problem is that the filter doesn't do what you want it to.
> It doesn't filter for loopback addresses.

I see it the same way. Did some testing:

<?php
$ips = array(
	'127.0.0.1',
	'::1',
	'192.168.1.1',
	'81.93.22.11'
);

foreach ($ips as $test) {
	echo('<br />');
	if (filter_var($test, FILTER_VALIDATE_IP, FILTER_FLAG_NO_PRIV_RANGE)) {
		echo($test . ' - internal');
	} else {
		echo($test . ' - external');
	}
}
?>

Result:
127.0.0.1 - internal
::1 - internal
192.168.1.1 - external
81.93.22.11 - internal

Not what we want to achieve I think.

I'd like to get my second patch comitted as is. If we need to change the
filtering to something more fancy, let's do this as a separate change.

Cheers,
Mario


More information about the TYPO3-team-core mailing list